Review Request: Zero fix for 32-bit platforms

[Gary Benson]

Christian Thalinger wrote:
> On Mon, 2010-01-18 at 11:09 +0000, Gary Benson wrote:
> > Recent changes in arguments.cpp mean that
> > os::allocatable_physical_memory is now always called at VM startup.
> > On 32-bit platforms this calls os::is_allocatable which was not
> > implemented in Zero.  This webrev implements this:
> > 
> >   http://cr.openjdk.java.net/~gbenson/zero-is_allocatable/
> > 
> > The implementation provided is essentially a copy of the one from
> > os_linux_x86.cpp.  It was contributed by Edward Nevill, an SCA
> > signatory.  I modified his contribution by replacing the AMD64
> > conditional with _LP64 to make the code generic.
> > 
> > Note that I added 2009 to the copyright header as well as 2010.
> > This was intentional: I modified that file several times in 2009,
> > and forgot to update the copyright each time :/
> > 
> > There is no bug filed for this issue yet.
> 
> I filed:
> 
> 6917698: os::is_allocatable Zero fix for 32-bit platforms
> 
> The changes look good.  Should I push it for you?  Who should be the
> contributor?

Yes, please push.  Put Ed as the contributor please.

Cheers,
Gary

-- 
http://gbenson.net/