Request for review (L): 6917766: JSR 292 needs its own deopt handler

Christian Thalinger Christian.Thalinger at Sun.COM
Mon Jan 25 08:15:01 PST 2010


On Thu, 2010-01-21 at 16:35 -0800, John Rose wrote:
> Reviewed.  But, can you factor the new assert code for frames some
> more?  I like what it does, but it is hard to read, because it uses a
> scratch frame to carry an argument, and it is repetitive.  It would be
> great if the 2-3 checks repeated could be merged into a single
> debug-only sanity check routine.

Yes, you're right.  Here is an updated webrev and I keep the check in
Deoptimization::fetch_unroll_info_helper:

http://cr.openjdk.java.net/~twisti/6917766/webrev.02/

-- Christian



More information about the hotspot-compiler-dev mailing list