Request for reviews (M): 6968368: SIGSEGV in the BCEscapeAnalyzer::copy_dependencies

Vladimir Kozlov vladimir.kozlov at oracle.com
Tue Jul 13 15:53:29 PDT 2010


Thank you, Tom, for both reviews.

Vladimir

Tom Rodriguez wrote:
> Looks good.
> 
> tom
> 
> On Jul 13, 2010, at 9:02 AM, Vladimir Kozlov wrote:
> 
>> http://cr.openjdk.java.net/~kvn/6968368/webrev
>>
>> Fixed 6968368: SIGSEGV in the BCEscapeAnalyzer::copy_dependencies
>>
>> Changes for 6966411 moved escape analysis into Optimize() method
>> after ResourceMark so on exit from Optimize() all data allocated
>> in resource area is freed. bcEscapeAnalyzer uses resource area
>> to keep dependency and bytecode analysis data and this data will
>> be lost on exit from Optimize(). The method compilation could be
>> retried (subsume_loads) with the same CI data but bcEscapeAnalyzer
>> dependency and bytecode analysis data are not regenerated and
>> contain garbage.
>>
>> Solution:
>> Use GrowableArray and VectorSet allocated in ciEnv arena.
>> Removed unused _stack field.
>>
>> Failed test, CTW, JPRT, nsk.stress
> 


More information about the hotspot-compiler-dev mailing list