Request for reviews (M): 6968368: SIGSEGV in the BCEscapeAnalyzer::copy_dependencies
Vladimir Kozlov
vladimir.kozlov at oracle.com
Wed Jul 14 09:44:32 PDT 2010
Thank you, Christian, for reviews
Vladimir
On 7/14/10 12:40 AM, Christian Thalinger wrote:
> On Tue, 2010-07-13 at 09:02 -0700, Vladimir Kozlov wrote:
>> http://cr.openjdk.java.net/~kvn/6968368/webrev
>>
>> Fixed 6968368: SIGSEGV in the BCEscapeAnalyzer::copy_dependencies
>>
>> Changes for 6966411 moved escape analysis into Optimize() method
>> after ResourceMark so on exit from Optimize() all data allocated
>> in resource area is freed. bcEscapeAnalyzer uses resource area
>> to keep dependency and bytecode analysis data and this data will
>> be lost on exit from Optimize(). The method compilation could be
>> retried (subsume_loads) with the same CI data but bcEscapeAnalyzer
>> dependency and bytecode analysis data are not regenerated and
>> contain garbage.
>>
>> Solution:
>> Use GrowableArray and VectorSet allocated in ciEnv arena.
>> Removed unused _stack field.
>>
>> Failed test, CTW, JPRT, nsk.stress
>
> Looks good. -- Christian
>
More information about the hotspot-compiler-dev
mailing list