Request for reviews (L): 6939203: JSR 292 needs method handle constants

[Tom Rodriguez]

On Jun 2, 2010, at 3:12 PM, John Rose wrote:

> On Jun 2, 2010, at 3:03 PM, Tom Rodriguez wrote:
> 
>> In c1_Runtime1.cpp, you've deleted the assignment to k in the ldc code:
>> 
>> -          k = resolved->klass_part()->java_mirror();
> 
> Yes, it's folded into the expression cc->resolve_constant, which has to know about MH constants too.

Maybe the klass_part()->java_mirror() part is but the local variable k isn't being set and it's used here:

    // convert to handle
    load_klass = Handle(THREAD, k);

So shouldn't it be?

+          k = cc->resolve_constant(CHECK);

tom

> 
> The particular line of code, plus preceding comment, was moved to constantPoolOopDesc::resolve_constant_at_impl.
> 
> -- John