Request for reviews (S): 6958254: -XX:+VerifyOops is broken on x86

[Tom Rodriguez]

Why didn't you ifdef _LP64 the rscratch1 pushes instead of using "if (rscratch1 != noreg)"?  You could also restore the registers in the stub using loads instead of emitting pops at the call site which would keep the code size down.  Turning on VerifyOops increases the code size quite a bit and adding pops will just make it worse.

tom

On Jun 3, 2010, at 10:37 AM, Vladimir Kozlov wrote:

> http://cr.openjdk.java.net/~kvn/6958254/webrev
> 
> Fixed 6958254: -XX:+VerifyOops is broken on x86
> 
> movptr() instruction in verify_oop() trashes r10 (rscratch1)
> since the stub address is far. And rax is not restored.