Request for reviews (S): 6730276: JDI_REGRESSION tests fail with "Error: count must be non-zero" error on x86

[Tom Rodriguez]

I don't think you should change the ones that don't have assert_non_zero since those presumably handle 0 properly.  The check just becomes extra overhead.  If we could confirm that all the other paths handle 0 then we could simply delete the assert_non_zero but I was afraid of auditing all that code to confirm handling of 0 which is why I suggested replacing it.  As far as I can tell they are all ok.

tom

On Jun 9, 2010, at 10:49 AM, Vladimir Kozlov wrote:

> http://cr.openjdk.java.net/~kvn/6730276/webrev
> 
> Fixed 6730276: JDI_REGRESSION tests fail with "Error: count must be non-zero" error on x86
> 
> Replace assert_non_zero with if (count == 0) return.
>