review (XS) for 6952176: Remove debug flag from adlc makefile for 6Update trains

Tom Rodriguez tom.rodriguez at oracle.com
Mon Jun 14 16:43:34 PDT 2010


Of course.  I only checked that the failure stopped happening, not that we still emitted -g for 4.x.  I'm going to use:

ifneq "$(shell expr \( $(CC_VER_MAJOR) \> 3 \) \| \( \( $(CC_VER_MAJOR) = 3 \) \& \( $(CC_VER_MINOR) \>= 3 \) \))" "0"

tom

On Jun 14, 2010, at 4:25 PM, Vladimir Kozlov wrote:

> I think it should be >=
> 
> + ifneq "$(shell expr \( \( $(CC_VER_MAJOR) = 3 \) \& \( $(CC_VER_MINOR) \> 3 \) \))" "0"
>                                            ^ \>=
> 
> Vladimir
> 
> Tom Rodriguez wrote:
>> http://cr.openjdk.java.net/~never/6952176
>> 6952176: Remove debug flag from adlc makefile for 6Update trains
>> Reviewed-by:
>> Some versions of gcc 3.2 have a bug that is triggered by the #line directives
>> we emit in adlc generated files so don't emit them on earlier versions of gcc.
>> Tested with jprt.



More information about the hotspot-compiler-dev mailing list