Request for reviews (S): 6932536: JSR 292 modified JDK MethodHandlesTest fails on x86_64
John Rose
John.Rose at Sun.COM
Fri Mar 5 16:51:55 PST 2010
On Mar 5, 2010, at 7:30 AM, Christian Thalinger wrote:
> http://cr.openjdk.java.net/~twisti/6932536/webrev.01/
Looks good; thanks. And thanks for extending the test suite!
-- John
P.S. I wish we could factor those ifdefs into the assembler. It would be possible (as it is on SPARC) if x86_32 allowed 64-bit values in one register. Perhaps there's a way to hide the distinction between a movq and two movl's (along with the tagged-stack-interpreter stuff) in an assembler macro. I think it would require an ADT which encapsulates either a single 64-bit reg or a pair of 32-bit regs (depending in CPU mode). That's not worth the effort.
But on SPARC, we should expect to have fewer ifdefs.
More information about the hotspot-compiler-dev
mailing list