review (S) for 6930043: C2: SIGSEGV in javasoft.sqe.tests.lang.arr017.arr01702.arr01702.loop_forw(II)I

Vladimir Kozlov Vladimir.Kozlov at Sun.COM
Fri Mar 12 15:05:33 PST 2010


Tom,

You removed lines 2225,2226 but where ctrl node comes from for next line?:

2243       ld_rng = (LoadRangeNode*)invar.clone(ld_rng, ctrl);

Thanks,
Vladimir

Tom Rodriguez wrote:
> http://cr.openjdk.java.net/~never/6930043
> 
> 6930043: C2: SIGSEGV in javasoft.sqe.tests.lang.arr017.arr01702.arr01702.loop_forw(II)I
> Reviewed-by:
> 
> The new loop predication code is missing logic to test that the
> initial value of the index is in range.  In many cases will be
> eliminated statically.  Tested with failing test.  Also tested that
> this new test doesn't affect the performance improvement we were
> seeing with scimark.
> 
> src/share/vm/opto/loopTransform.cpp
> test/compiler/6930043/Test6930043.java


More information about the hotspot-compiler-dev mailing list