Request for reviews (XL): 6939134: JSR 292 adjustments to method handle invocation

[John Rose]

On Mar 30, 2010, at 2:49 AM, Christian Thalinger wrote:

> On Mon, 2010-03-29 at 18:53 -0700, John Rose wrote:
>> http://cr.openjdk.java.net/~jrose/6939134/hs-webrev.00/
> 
> src/share/vm/prims/methodHandles.cpp:
> 
> 2103     // happens, when we call resolve_NemberName.
> 
> Typo.

Thanks.

> src/share/vm/prims/methodHandles.hpp:
> 
> 273               //|(1<<sun_dyn_AdapterMethodHandle::OP_SPREAD_ARGS) //BUG!

It's a crasher in the adapter assembly code for spread-args.  So at present the Java code doesn't use that kind of adapter; it uses something more roundabout and general. 

> Otherwise looks good.  When will the MH.invoke name be removed?

When or before we remove the experimental status of the JSR 292 stuff.  Which means before JDK7 feature-complete.

-- John