Request for reviews (XL): 6939134: JSR 292 adjustments to method handle invocation

[John Rose]

Christian's comments, plus the move mentioned below, are incorporated in the updated webrev:
  http://cr.openjdk.java.net/~jrose/6939134/hs-webrev.01

On Mar 30, 2010, at 3:12 PM, John Rose wrote:

> On Mar 30, 2010, at 2:49 AM, Christian Thalinger wrote:
> 
>> src/share/vm/prims/methodHandles.hpp:
>> 
>> 273               //|(1<<sun_dyn_AdapterMethodHandle::OP_SPREAD_ARGS) //BUG!
>> 
>> What bug do we have here?
> 
> I'm going to move that constant into the platform-specific assembly code where it belongs.  AFAIK, the bug is only with the x86 code.

-- John

P.S.  I pushed a draft fix to the OP_SPREAD_ARGS bug, as a separate patch, to the mlvm repo.  Part of the bug involved getting the spread arguments backwards, since JVM arguments are stored in stack memory in reverse order from their appearance in varargs arrays.  Perhaps that bug is in the sparc version also.