Request for reviews (M): 6930772: JSR 292 needs to support SPARC C1

[John Rose]

On May 3, 2010, at 8:33 AM, Christian Thalinger wrote:

> On Wed, 2010-04-28 at 12:23 -0700, John Rose wrote:
>> Suggestion:  Grep for is_method_handle_adapter in this file, and adapt any relevant changes:
>> 
>> http://hg.openjdk.java.net/mlvm/mlvm/hotspot/file/tip/meth-ing-6939134.patch
>> 
>> (My bad that it's not pushed yet.)
> 
> Now it is.  Is it OK that 3 tests of MethodHandlesTest are failing
> now?  

No, that's not OK; I always (?!?) test MHT before pushing.  Which patches (or is it the JDK7 push), which version of MHT, and which 3 tests?

Possible explanation:  The tests change (improve) with both meth-ing and meth-bcp.  It's likely there's a temporary version skew somewhere.

> Additionally I found a bug in SPARC C1 with one of the tests (I think
> it's testCastFailure).  Obviously I have to fix that before pushing.

Foo.  Let me know if I can help.  BTW, did the cpindex changes for sparc break anything on your end?

-- John