Request for reviews (M): 6930772: JSR 292 needs to support SPARC C1

[Christian Thalinger]

On Mon, 2010-05-03 at 23:54 -0700, John Rose wrote:
> On May 3, 2010, at 3:17 PM, John Rose wrote:
> 
> > On May 3, 2010, at 11:44 AM, Christian Thalinger wrote:
> > 
> >> JUnit version 4.4
> >> .IIIIII..E...E...................E
> >> Time: 0.731
> >> There were 3 failures:
> >> 1) testFindVirtual(MethodHandlesTest)
> >> java.lang.AssertionError: expected:<(MethodHandlesTest$Example)void> but was:<(java.lang.Object)void>
> > 
> > I'll make sure the updated unit test gets pushed to hotspot-comp/jdk/.
> 
> I pushed the JDK update for meth-bcp-6939196.patch to hotspot-comp/jdk/.

All tests pass now.  Thanks.

> 
> You are right that this shouldn't affect just a fastdebug build.
> 
> Maybe the discrepancy is a problem with CHECK_UNHANDLED_OOPS, which is
> turned on *only* with Solaris fastdebug builds.
> If it's not a Solaris build, or it's product or plain debug build,
> CHECK_UNHANDLED_OOPS will not do its special thing.
> If in addition it is a SPARC-only problem, that narrows it down to an
> occurence of the name 'oop' methodHandles_sparc or similar code.

Ohh, it also happens with a debug build when using -Xbatch.  It seems
the compiler was too slow to finish the compile.  And it also fails with
C2 using -Xbatch.  So this is a more basic bug.

-- Christian