Review Request: Zero stack improvements

Gary Benson gbenson at redhat.com
Thu May 6 04:42:57 PDT 2010


Christian Thalinger wrote:
> On Wed, 2010-05-05 at 16:00 +0100, Gary Benson wrote:
> > In Zero, at present, the logic for determining the size of the Zero
> > stack is in the call stub.  This webrev moves this logic into a
> > method of the ZeroStack class, ZeroStack::suggest_size().  This
> > consolidates access to the ABI stack, and includes the shadow pages
> > in all calculations.  (Previously the call stub did not consider the
> > shadow pages, which led to some odd sizes being chosen on systems
> > with large pages.)
> > 
> >   http://cr.openjdk.java.net/~gbenson/zero-stack-improvements/
> > 
> > I don't have a bug id for this.
> 
> 6950178: Zero stack improvements
> 
> Changes are good and it's in the queue.

Thank you :)

Cheers,
Gary

-- 
http://gbenson.net/


More information about the hotspot-compiler-dev mailing list