Request for reviews (L): 6951083: oops and relocations should part of nmethod not CodeBlob
Vladimir Kozlov
vladimir.kozlov at oracle.com
Wed May 12 10:15:57 PDT 2010
src/share/vm/code/oopRecorder.hpp
// => code->copy_oops(_handles)
^ nm->
src/share/vm/code/nmethod.hpp
Add embedded oop table information into nmethod's comment:
104 // A nmethod contains:
105 // - header (the nmethod structure)
src/share/vm/includeDB_core
Why it is codeBlob.hpp and not nmethod.cpp?:
+ codeBlob.hpp jniHandles.hpp
Vladimir
Christian Thalinger wrote:
> http://cr.openjdk.java.net/~twisti/6951083/webrev.01/
>
> 6951083: oops and relocations should part of nmethod not CodeBlob
> Summary: This moves the oops from Codeblob to nmethod.
> Reviewed-by:
>
> This moves the oops from Codeblob to nmethod and is a preparation for
> better oop-loading code.
>
> agent/src/share/classes/sun/jvm/hotspot/code/CodeBlob.java
> agent/src/share/classes/sun/jvm/hotspot/code/NMethod.java
> agent/src/share/classes/sun/jvm/hotspot/utilities/PointerFinder.java
> src/cpu/sparc/vm/nativeInst_sparc.cpp
> src/os/solaris/dtrace/generateJvmOffsets.cpp
> src/os/solaris/dtrace/libjvm_db.c
> src/share/vm/asm/codeBuffer.hpp
> src/share/vm/code/codeBlob.cpp
> src/share/vm/code/codeBlob.hpp
> src/share/vm/code/codeCache.cpp
> src/share/vm/code/compiledIC.cpp
> src/share/vm/code/nmethod.cpp
> src/share/vm/code/nmethod.hpp
> src/share/vm/code/oopRecorder.cpp
> src/share/vm/code/oopRecorder.hpp
> src/share/vm/code/relocInfo.cpp
> src/share/vm/code/relocInfo.hpp
> src/share/vm/includeDB_core
> src/share/vm/memory/iterator.cpp
> src/share/vm/runtime/sharedRuntime.cpp
> src/share/vm/runtime/vmStructs.cpp
>
More information about the hotspot-compiler-dev
mailing list