review (XS) for 6953539: after 6892658 c1 no longer inlines StringBuffer.append

Tom Rodriguez tom.rodriguez at oracle.com
Tue May 18 11:14:38 PDT 2010


http://cr.openjdk.java.net/~never/6953539

6953539: after 6892658 c1 no longer inlines StringBuffer.append
Reviewed-by:

6892658 added intrinsic ids for several StringBuffer/StringBuilder
methods which triggered some long dormant logic in
try_inline_intrinsic which bails out of inlining if an intrinsic is
synchronized.  It really shouldn't be a full bailout, it should simply
return false to indicate that it didn't do anything.  Tested by
inspecting PrintInlining output.


More information about the hotspot-compiler-dev mailing list