Request for reviews .06 (M): 6930772: JSR 292 needs to support SPARC C1

[Christian Thalinger]

On Mon, 2010-05-10 at 14:12 +0200, Christian Thalinger wrote:
> On Mon, 2010-05-10 at 13:51 +0200, Christian Thalinger wrote:
> > On Tue, 2010-05-04 at 21:52 +0200, Christian Thalinger wrote:
> > > On Tue, 2010-05-04 at 10:34 -0700, John Rose wrote:
> > > > On May 4, 2010, at 7:20 AM, Christian Thalinger wrote:
> > > > 
> > > > > I currently don't see why this should be a problem since O5_savedSP
> > > > > should contain the correct sender SP.
> > > > 
> > > > Maybe O5 is getting trashed by a trip through C2I or I2C adapters? 
> > > 
> > > Hmm, not sure where that could happen.  I'll look again.
> > > 
> > > > Could the throwing MH in question be getting called from compiled code
> > > > maybe?
> > > 
> > > How could that happen?  I thought every call to a MH needs to go through
> > > c2i before.
> > 
> > Can't we simply not cut back to the caller's SP?  Since SP should be
> > restored correctly from FP during unwind anyways.
> 
> ...actually from L7.  -- Christian

Finally we found the bug and this should be the final version to be
commited:

http://cr.openjdk.java.net/~twisti/6930772/webrev.06/

The only change between .05 is:

http://cr.openjdk.java.net/~twisti/6930772/webrev.06/src/cpu/sparc/vm/methodHandles_sparc.cpp.udiff.html

-- Christian