Request for reviews (XS): 6996240: The BitSet.length method sometimes returns an index+1 value less than that of the highest bit set.

Tom Rodriguez tom.rodriguez at oracle.com
Tue Nov 2 11:48:35 PDT 2010


You can also just declare dst to be iRegIsafe which is an integer held in a register that's also safe for longs.  That might give a better register allocation.  Either way is fine though.

tom

On Nov 2, 2010, at 10:56 AM, Christian Thalinger wrote:

> http://cr.openjdk.java.net/~twisti/6996240/webrev.01/
> 
> 6996240: The BitSet.length method sometimes returns an index+1 value less than that of the highest bit set.
> Reviewed-by:
> 
> It's a problem with countLeadingZerosL.  dst is a iRegI but is used as
> temporary for an iRegL OR value.
> 
> The fix is to use a second temporary iRegL register for the OR value.
> 
> Tested with the failing testcase attached to the CR.



More information about the hotspot-compiler-dev mailing list