Request for reviews (XS): 6996240: The BitSet.length method sometimes returns an index+1 value less than that of the highest bit set.

[Vladimir Kozlov]

Yes, I missed at first that it happens in 32 bit mode.

Thanks,
Vladimir

Tom Rodriguez wrote:
> On Nov 2, 2010, at 12:48 PM, Vladimir Kozlov wrote:
> 
>> Thank you, Christian
>>
>> All registers on sparc are 64 bit and all operations are 64 bit.
>> Which instruction produce wrong value? Did you step per instruction in debugger?
> 
> In 32 bit only the g's and o's have their full 64 bit value preserved by the OS.  The i's and l's are saved and restored in register window stack space that only has room for their 32 bit values.
> 
> tom
> 
>> Thanks,
>> Vladimir
>>
>> Christian Thalinger wrote:
>>> http://cr.openjdk.java.net/~twisti/6996240/webrev.01/
>>> 6996240: The BitSet.length method sometimes returns an index+1 value less than that of the highest bit set.
>>> Reviewed-by:
>>> It's a problem with countLeadingZerosL.  dst is a iRegI but is used as
>>> temporary for an iRegL OR value.
>>> The fix is to use a second temporary iRegL register for the OR value.
>>> Tested with the failing testcase attached to the CR.
>