Request for reviews (S): 6991188: C2 Crashes while compiling method

[Tom Rodriguez]

Typo:

+     // Possible infinit build_connection_graph loop.

Why 10?  How many passes does it normally take?  Could this process only the nodes which changed or does it really need to reprocess every node?

tom

On Nov 2, 2010, at 3:27 PM, Vladimir Kozlov wrote:

> http://cr.openjdk.java.net/~kvn/6991188/webrev.00
> 
> Fixed 6991188: C2 Crashes while compiling method
> 
> Construction of Connection Graph during EA relied on
> DU relation corresponds to nodes index so that def
> nodes processed before their uses. Move EA after
> IGVN (for 6966411 fix broke that. Because of that
> not all Graph edges will be created leading to
> incorrect EA results and incorrect Ideal graph.
> 
> Walk over interesting nodes (AddP, LoadP, StoreP)
> several times until no new edges are created.
> Set limit on iterations.
> 
> Tested with assert in iterations bailout code and
> calls to PhaseIdealLoop::verify() (removed from
> final changes). Passed JPRT, full CTW, nsk.
>