Request for reviews (S): 6991188: C2 Crashes while compiling method

[Vladimir Kozlov]

Thank you, Christian

Vladimir

On 11/3/10 1:13 AM, Christian Thalinger wrote:
> On Nov 2, 2010, at 11:27 PM, Vladimir Kozlov wrote:
>> http://cr.openjdk.java.net/~kvn/6991188/webrev.00
>>
>> Fixed 6991188: C2 Crashes while compiling method
>>
>> Construction of Connection Graph during EA relied on
>> DU relation corresponds to nodes index so that def
>> nodes processed before their uses. Move EA after
>> IGVN (for 6966411 fix broke that. Because of that
>> not all Graph edges will be created leading to
>> incorrect EA results and incorrect Ideal graph.
>>
>> Walk over interesting nodes (AddP, LoadP, StoreP)
>> several times until no new edges are created.
>> Set limit on iterations.
>>
>> Tested with assert in iterations bailout code and
>> calls to PhaseIdealLoop::verify() (removed from
>> final changes). Passed JPRT, full CTW, nsk.
>>
>
>
> src/share/vm/opto/escape.hpp:
> + // Add a edge of the specified type pointing to the specified target.
> + // Set _progress if new esge is added.
> I think this should be "an edge" and esge -> edge.
>
> -- Christian