Request for reviews (S): 6997459: JSR 292 after 6994093 getting: on return to interpreted call, restored SP is corrupted

John Rose john.r.rose at oracle.com
Thu Nov 4 12:09:38 PDT 2010


Reviewed; good fix.  Thanks for jumping on it so quickly.  -- John

On Nov 4, 2010, at 4:55 AM, Christian Thalinger wrote:

> http://cr.openjdk.java.net/~twisti/6997459/webrev.01/
> 
> 6997459: JSR 292 after 6994093 getting: on return to interpreted call, restored SP is corrupted
> Reviewed-by:
> 
> After 6994093 running a testcase on SPARC that should throw a
> WrongMethodTypeException results in an assert.  The problem is that
> the change of 6994093 destroys O5 which is the saved sender SP and
> that leads to bogus FP values.
> 
> The fix is to change temporary register usage in
> MethodHandles::generate_method_handle_interpreter_entry to preserve
> O5.
> 
> Tested with failing testcase.



More information about the hotspot-compiler-dev mailing list