Request for review(S): 7000349: Tiered reacts incorrectly to C1 compilation failures

Igor Veresov igor.veresov at oracle.com
Tue Nov 16 15:43:56 PST 2010


Thanks, Vladimir!

On 11/15/10 9:35 PM, Vladimir Kozlov wrote:
> Looks good.
>
> Vladimir
>
> On 11/15/10 8:12 PM, Igor Veresov wrote:
>> Tiered has the following problems with C1 compile failures:
>>
>> 1. Compile broker marks method as non-compilable at all levels if C1
>> compilation fails because C1 doesn't fill the
>> failure_reason in ciEnv.
>> 2. If a method cannot be compiled at any of the C1 levels the tiered
>> policy tries to immediately compile it with C2
>> instead of continuing profiling in the interpreter.
>> 3. If C2 fails to compile the broker will make the method not
>> compilable for C1 also, which is wrong.
>>
>> Also, C1 needs to report the failure reason.
>>
>> Webrev: http://cr.openjdk.java.net/~iveresov/7000349/webrev.00
>>
>> Thanks,
>> igor



More information about the hotspot-compiler-dev mailing list