review (XS) for 6875026: CTW failure jdk6_18/hotspot/src/share/vm/c1/c1_LinearScan.cpp:5486

[Igor Veresov]

Looks good!

igor

On 11/30/10 1:13 PM, Tom Rodriguez wrote:
> http://cr.openjdk.java.net/~never/6875026
>
> 6875026: CTW failure jdk6_18/hotspot/src/share/vm/c1/c1_LinearScan.cpp:5486
> Reviewed-by:
>
> Constructing the CodeEmitInfo for an instruciton may result in
> evaluation of instructions which are only used in the ValueStack.
> This should always been done before any argument setup with fixed
> registers.  arraycopy uses all the registers and this can cause us to
> fail our allocation.  The fix is to make the code look like the sparc
> code and create the CodeEmitInfo early.  Tested with test from report.
>
> src/cpu/x86/vm/c1_LIRGenerator_x86.cpp