review (S) for 6989736: fix mapfile warnings on solaris

[John Coomes]

Vladimir Kozlov (vladimir.kozlov at oracle.com) wrote:
> Tom,
> 
> It seems, nobody want to spend time to regenerate reorder files
> for several years already. What we only do is removing lines
> from these files which produce warnings. ...

Right.  The files are so out of date they may not be improving
performance, and for all we know could be hurting it.  I'd vote to
just get rid of it all until someone automates it or commits to
keeping it up to date.  I filed 6989819.

> Otherwise looks good.

Yes, the changes look fine to me, too.

-John

> Tom Rodriguez wrote:
> > http://cr.openjdk.java.net/~never/6989736
> > 
> > 6989736: fix mapfile warnings on solaris
> > Reviewed-by:
> > 
> > The map files are getting out of date resulting in a bunch of warnings
> > for product builds so it's time to clean them again.  The 64 bit
> > tiered reorder files have only recently started being used and those
> > have a lot of entries out of date.  I also fixed a minor build issue
> > where the first build of the adlc didn't run the fix_lines portion of
> > the adlc_updater which caused the next incremental build to regenerate
> > some files because the #line directives had changed.  Tested by
> > building each target.  I attached the automated script I used for this
> > to the bug report.