review (S) for 6980792: Crash "exception happened outside interpreter, nmethods and vtable stubs (1)"

[Vladimir Kozlov]

Tom,

Looks good.

Thanks,
Vladimir

Tom Rodriguez wrote:
> I added this:
> 
> const TypeFunc* OptoRuntime::array_fill_Type() {
>   // create input type (domain): pointer, int, size_t
> 
> tom
> 
> On Oct 7, 2010, at 12:03 PM, Vladimir Kozlov wrote:
> 
>> Tom,
>>
>> could you add comment with array_fill signature for OptoRuntime::array_fill_Type()?
>> Also add comments what first and second arguments are.
>>
>> thanks,
>> Vladimir
>>
>> Tom Rodriguez wrote:
>>> http://cr.openjdk.java.net/~never/6980792
>>> 6980792: Crash "exception happened outside interpreter, nmethods and vtable stubs (1)"
>>> Reviewed-by:
>>> The calls to checkcast_arraycopy were passing ints to functions which
>>> expected long in 64 bit so unclean ints would cause failures since
>>> the count would appear to be extremely large.  I also moved the
>>> assert_clean_int test above the check for copies within single array
>>> since it was the true source of the problem.  The recently added fill
>>> code had the same problem.  Fixed by adding appropriate conversions.
>>> Tested using failing test case from report.
>