Request for reviews (M): 6829194: JSR 292 needs to support compressed oops

[John Rose]

On Oct 7, 2010, at 3:22 PM, Vladimir Kozlov wrote:

> "word" is not concrete size in computers :) In x86 it could be 2 bytes (16 bits).

Oops.  I meant the size in bytes is wordSize, HeapWordSize, sizeof(intptr_t), sizeof(void*).  But the term "WORD" in that code means int32_t.  It looks like you spotted a pre-existing bug for LP64.  I suggest:

+ FieldAllocationType new_atype = (wordSize==longSize) ? NONSTATIC_DOUBLE : NONSTATIC_WORD;
+ assert(wordSize == longSize || wordSize == jintSize, "ILP32 or LP64");

Also the guard on "fac_ptr->nonstatic_double_count += 1" needs to be similar.

Christian, the assembler changes look good, and (although I haven't read every line yet) the changes from ld_ptr to load_heap_oop, etc., look good.

-- John

> I don't understand why its size should depend on UseCompressedOops flag if it is raw.
> 
> Vladimir
> 
> John Rose wrote:
>> On Oct 7, 2010, at 2:47 PM, Vladimir Kozlov wrote:
>>> What size of MethodHandle.vmentry in 64bit VM?
>> It's a raw machine word, not compressed.
>> -- John