Request for reviews (S): 6987555: JSR 292 unboxing to a boolean value fails on big-endian SPARC

[Tom Rodriguez]

On Oct 12, 2010, at 8:49 AM, Christian Thalinger wrote:

> On 9/30/10 7:45 PM, Christian Thalinger wrote:
>> On Wed, 2010-09-29 at 09:40 -0700, John Rose wrote:
>>> On Sep 29, 2010, at 9:22 AM, Tom Rodriguez wrote:
>>> 
>>>> Why aren't the values dependent on which operation is being performed then?
>>> 
>>> They certainly can be.  That will move the complication out of the
>>> assembly code. (And into methodHandles.cpp, with a new CPU-specific
>>> query, plus a new but useful distinction between value conversion and
>>> unboxing.)  I'm fine with doing it either way.
>> 
>> I will look into that and try to come up with a new patch.
> 
> http://cr.openjdk.java.net/~twisti/6987555/webrev.02/
> 
> That works and seems to be a good patch.  It also adds a compiler test.

Looks good.  For consistency shouldn't methodHandles_x86.cpp use the same values?

tom

> 
> -- Christian