Request for reviews (S): 6991596: JSR 292 unimplemented adapter_opt_i2i and adapter_opt_l2i on SPARC

[John Rose]

On Oct 13, 2010, at 11:42 AM, Christian Thalinger wrote:

> http://cr.openjdk.java.net/~twisti/6991596/webrev.01/
> 
> 6991596: JSR 292 unimplemented adapter_opt_i2i and adapter_opt_l2i on SPARC
> Reviewed-by:
> 
> On SPARC adapter_opt_i2i and adapter_opt_l2i are still unimplemented.
> This needs to be filled in.

Good.

> This change also adds a testcase that tests as much conversions as
> currently possible (there are some bugs in the current RI).


That's a very nice test case!

I believe the newer version of javac support for method handles has been released.  If so, compiling the test case will cause warnings, and those warnings will turn to errors as JSR 292 finalizes.  Please try the new syntax:

  - boolean a = mh1.<boolean>invokeExact((boolean) x);
  - boolean a = (boolean) mh1.invokeExact((boolean) x);

Suggestion:  To make the overall structure of the test code easier to read, factor the long initializers for mh1 and mh2 into suitably parameterized subroutines.

-- John