Request for reviews (S): 6991596: JSR 292 unimplemented adapter_opt_i2i and adapter_opt_l2i on SPARC

[Rémi Forax]

  Le 14/10/2010 10:43, Christian Thalinger a écrit :
> On Oct 14, 2010, at 1:32 AM, John Rose wrote:
>>> This change also adds a testcase that tests as much conversions as
>>> currently possible (there are some bugs in the current RI).
>>
>>
>> That's a very nice test case!
>>
>> I believe the newer version of javac support for method handles has 
>> been released.  If so, compiling the test case will cause warnings, 
>> and those warnings will turn to errors as JSR 292 finalizes.  Please 
>> try the new syntax:
>>
>>  - boolean a = mh1.<boolean>invokeExact((boolean) x);
>>  - boolean a = (boolean) mh1.invokeExact((boolean) x);
>
> I know and I also tried that but it seems there is a bug somewhere:
>
> Exception in thread "main" java.dyn.WrongMethodTypeException: (Z)Z 
> cannot be called as (Z)Ljava/lang/Object;

Your javac just doesn't understand the new syntax.

>
>>
>> Suggestion:  To make the overall structure of the test code easier to 
>> read, factor the long initializers for mh1 and mh2 into suitably 
>> parameterized subroutines.
>
>
> Good idea.
>
> -- Christian

Rémi