Request for Review(S): Ifop optimization for c1
Tom Rodriguez
tom.rodriguez at oracle.com
Thu Oct 14 09:35:06 PDT 2010
Looks good.
tom
On Oct 14, 2010, at 4:30 AM, Roland Westrelin wrote:
>
> Hi Rémi,
>
>> A minor comment from an amateur.
>> In c1_Optimizer.cpp, in CE_Eliminator::make_ifop:
>>
>> Constant* x_const = x->as_Constant();
>>
>> should be computed only in the else branch and not before
>>
>> if (x_ifop != NULL)
>
> Thanks for the comment. I've updated the webrev:
> http://cr.openjdk.java.net/~roland/6991577/webrev.01/
>
> Roland.
More information about the hotspot-compiler-dev
mailing list