review (S) for 6968367: can_post_on_exceptions is still using VM_DeoptimizeFrame in some places

Vladimir Kozlov vladimir.kozlov at oracle.com
Mon Oct 18 12:51:31 PDT 2010


Looks good.

There are typos

"frmaes" in vm_operations.hpp:

+ // Deopt helper that can deoptimize frmaes in threads other than the

"doptimize" in deoptimization.hpp:

+   // VM_DeoptimizeFrame otherwise, doptimize directly.

Thanks,
Vladimir

Tom Rodriguez wrote:
> http://cr.openjdk.java.net/~never/6968367
> 
> 6968367: can_post_on_exceptions is still using VM_DeoptimizeFrame in some places
> Reviewed-by:
> 
> The fix for 6902182 changed some call sites where deopt is needed to
> call directly into deoptimize_frame instead of using
> VM_DeoptimizeFrame but it missed quite a few places, particularly in
> the client compiler.  Instead of directly modifying each site to use
> the appropriate version I modified Deoptimization::deoptimize_frame to
> select the appropriate version, made VM_DeoptimizeFrame private, and
> updated all call sites to use the main entry point.  Tested with all
> the nsk JVMTI tests.


More information about the hotspot-compiler-dev mailing list