Request for review (L): 6964498: JSR 292 invokedynamic sites need local bootstrap methods

[John Rose]

On Sep 7, 2010, at 2:03 AM, Christian Thalinger wrote:

> On Sun, 2010-09-05 at 00:00 -0700, John Rose wrote:
>> The JVM changes for 6964498 were pushed 7 weeks ago.  Here are the
>> associated JDK changes:
>> 
>> http://cr.openjdk.java.net/~jrose/6964498/jdk-webrev.01
> 
> src/share/classes/java/dyn/CallSite.java:
> 
> 39  * operations are attempted), the call site msut be linked to
> 
> Typo.
> 
> src/share/classes/java/dyn/package-info.java:
> 
> 203  * After resolution, the linkage process mail fail in a variety of ways.
> 
> Typo.

Thanks; fixed.

> src/share/classes/java/dyn/Dependency.java:
> 
>  41     /** Make a new, unique dependency which has no relation to any class.
>  42      *  The string is used solely by the {@code toString} method, but should be
>  43      *  something that conveys the purpose of this dependency.
>  44      */
> 
> Hmm.  Dependency extends Object and I don't see a toString method.

Thanks.  I moved the dependency stuff into its own webrev; review request forthcoming.

BTW, this is Reference Implementation work in parallel with the EG discussions.  As the EG discussions converge there will of course be more adjustments.  I have filed an omnibus bug to handle a round of miscellaneous changes:  6981777 implement JSR 292 EG adjustments from summer 2010.  The current series of reviews is grouped by functional feature.

-- John