Request for review(XXS): 6984056: C1: incorrect code for integer constant addition on x64
Igor Veresov
igor.veresov at oracle.com
Sat Sep 11 00:14:14 PDT 2010
Thanks, Vladimir!
On 9/10/10 8:03 PM, Vladimir Kozlov wrote:
> Looks good.
>
> Vladimir
>
> On 9/10/10 7:37 PM, Igor Veresov wrote:
>> C1 generates incorrect code for addition of a constant to an int.
>> Instead of emitting a 32bit arithmetic operation it
>> does 64bit. That causes usage of the upper bits instead of
>> overflowing, which causes incorrect results.
>>
>> Tested with the failing nightly test.
>>
>> Webrev: http://cr.openjdk.java.net/~iveresov/6984056/webrev.00/
>>
>>
>> Thanks,
>> igor
More information about the hotspot-compiler-dev
mailing list