review (S) for 6986028: assert(_base == Int) failed: Not an Int in CmpINode::sub

[Tom Rodriguez]

Thanks!

tom

On Sep 22, 2010, at 1:25 PM, Christian Thalinger wrote:

> On Wed, 2010-09-22 at 13:10 -0700, Tom Rodriguez wrote:
>> http://cr.openjdk.java.net/~never/6986028
>> 
>> 6986028: assert(_base == Int) failed: Not an Int in CmpINode::sub
>> Reviewed-by:
>> 
>> One of the places where a method is being matched wasn't checking the
>> signature so it picked up an argument of the wrong type which resulted
>> in errors when we tried to do math on it.  I changed it to use the
>> intrinsic id and fixed a couple others to also use the intrinsic id.
>> I checked the other sites to make sure they were checking the
>> signature as well and added non static as well.  Tested with failing
>> test from report.
> 
> Looks good.  -- Christian
>