review (S) for 6972540: sun/nio/ch/SocketChannelImpl compilation crashed when executing CompileTheWorld

[Tom Rodriguez]

On Sep 22, 2010, at 2:46 PM, Vladimir Kozlov wrote:

> Tom,
> 
> Changes looks good.
> Did you test 64-bit C1 which could be affected by these changes?

No i didn't but it's really about abstract typing in the LIR and doesn't effect code generation.  I can run CTW if you want.

tom

> 
> Thanks,
> Vladimir
> 
> Tom Rodriguez wrote:
>> http://cr.openjdk.java.net/~never/6972540
>> 6972540: sun/nio/ch/SocketChannelImpl compilation crashed when executing CompileTheWorld
>> Reviewed-by:
>> The fix 6932496 exposed T_ADDRESS as a constant so that deopt with
>> jsr's could work properly.  Since it didn't fully expose T_ADDRESS as
>> a support lir type it create type mismatches that showed up in some
>> complex cases.  The fix is support T_ADDRESS in the LIR directly.
>> Tested with full CTW.