Request for reviews (XS): 6986944: JSR 292 assert(caller_nm->is_method_handle_return(caller_frame.pc())) failed: must be MH call site

Tom Rodriguez tom.rodriguez at oracle.com
Thu Sep 23 12:55:01 PDT 2010


Looks good.

tom

On Sep 23, 2010, at 10:42 AM, Christian Thalinger wrote:

> http://cr.openjdk.java.net/~twisti/6986944/webrev.01/
> 
> 6986944: JSR 292 assert(caller_nm->is_method_handle_return(caller_frame.pc())) failed: must be MH call site
> Reviewed-by:
> 
> The problem is that C1 calls ciMethod::is_method_handle_invoke in
> LIRGenerator::do_Invoke. When the target is not loaded yet but is a
> MH call site, the method returns false and it's not registered as a MH
> invoke.
> 
> The fix is to restore the old logic, but only on the non-loaded path.
> 
> Tested with MethodHandlesTest.
> 
> This change also includes a build fix for newer GCCs.
> 
> 
> 



More information about the hotspot-compiler-dev mailing list