review (XS) for 6987763: assert(kind() == EmptyExceptionState) failed: only EmptyExceptionStates can be modified

[Tom Rodriguez]

On Sep 27, 2010, at 3:18 PM, Vladimir Kozlov wrote:

> Tom,
> 
> could you put kind() == ExceptionState inside ()?
> Otherwise looks good.

Sure.  Thanks!

tom

> 
> Thanks,
> Vladimir
> 
> Tom Rodriguez wrote:
>> http://cr.openjdk.java.net/~never/6987763
>> 6987763: assert(kind() == EmptyExceptionState) failed: only EmptyExceptionStates can be modified
>> Reviewed-by: roland
>> The fix for 6987763 aggressively kills unusable locals in ValueStacks
>> and there's some special case logic to keep these locals alive for
>> JVMTI.  An assert that should have been relaxed was missed leading to
>> lots of tests failing.  The fix is to properly relax this assert.
>> The original changes for 6987763 were tested with the nsk tests but we
>> rearranged some code in what was thought to be a benign way and didn't
>> rerun the tests which is why this was missed.  I've rerun all the nsk
>> JVMTI related tests and it looks good.