review (S) for 6968348: Byteswapped memory access can point to wrong location after JIT
Tom Rodriguez
tom.rodriguez at oracle.com
Wed Sep 29 18:25:44 PDT 2010
http://cr.openjdk.java.net/~never/6968348
6968348: Byteswapped memory access can point to wrong location after JIT
Reviewed-by:
x86_64.ad has match rules for (Store (ReverseBytes val)) but the
definition is buggy since the val can be used in address of the store.
It also doesn't record that it changes the input value. The fix is to
simply remove these rules since they are no better than what we'd get
otherwise. x86_32.ad doesn't have these rules. sparc.ad does but it
can generate better code for these forms because it can use the byte
swapped ASI and doesn't have to modify the register before storing it.
Tested with new test case.
More information about the hotspot-compiler-dev
mailing list