review (S) for 6968348: Byteswapped memory access can point to wrong location after JIT

Ulf Zibis Ulf.Zibis at gmx.de
Thu Sep 30 15:01:04 PDT 2010


  Am 30.09.2010 19:25, schrieb Tom Rodriguez:
> On Sep 30, 2010, at 7:08 AM, Ulf Zibis wrote:
>
>> - Why do you increment by 8 in the Test?
> Because i'm storing longs.  unsafe operates on direct addresses.
Hm, but you are storing in a long[], not a byte[], or do I miss something?
Will have an additional look at it tomorrow.

>> - ARRAY_LONG_BASE_OFFSET in capital letters is misleading to the reader, as this variable is not a final constant.
> Ok.
I have an idea for an alternative. Are you interested?

-Ulf



More information about the hotspot-compiler-dev mailing list