UseFastEmptyMethods/UseFastAccessorMethods considered harmful

[Tom Rodriguez]

On Apr 1, 2011, at 2:39 AM, Gary Benson wrote:

> Hi all,
> 
> I just spotted that UseFastEmptyMethods and UseFastAccessorMethods
> are now off by default.  Zero and Shark both benefit hugely from
> having these on, especially for accessors.  Would it be possible
> to make it platform-specific somehow?

I had considered turning them on in interpreter only mode but that wouldn't help Shark.  Maybe I should restore the default and just turn them off in Arguments::set_mode_flags for COMPILER1 || COMPILER2.  Otherwise we'd need to made them product_pd which is kind of a pain.  I'll send out an updated review.

tom

> 
> Thanks,
> Gary
> 
> -- 
> http://gbenson.net/