review(M): 7034967: C1: assert(false) failed: error (assembler_sparc.cpp:2043)

[Igor Veresov]

Thanks Vladimir and Tom!

igor

On 4/8/11 4:17 PM, Tom Rodriguez wrote:
> Looks good.
>
> tom
>
> On Apr 8, 2011, at 3:47 PM, Igor Veresov wrote:
>
>> The assert is a verification failure originated from LIR_Assembler::emit_unwind_handler() complaining that the exception oop is null. The verification code was invalid, because in C1_MacroAssembler::verify_not_null_oop() we used br_zero() to check for null, which actually checks only the least significant 32bits. Now br_notnull is used instead.
>>
>> Also, I found that VerifyOops didn't work with 64bit C1 (both x64 and sparc), which is also fixed.
>>
>>
>> Webrev: http://cr.openjdk.java.net/~iveresov/7034967/webrev.00/
>>
>>
>> Thanks,
>> igor
>