Request for review (S): 7018355: JSR 292: VM crash in DefNewGeneration::copy_to_survivor_space

[Christian Thalinger]

John suggested:

"Consider changing return-by-reference of klassOop to rbr of a handle. Avoid the scoped oop temp."

So I changed MethodHandles::decode_* function to take a KlassHandle and return a methodHandle instead of oops which makes the uses of these methods simpler.

webrev udpated.

-- Christian

On Apr 13, 2011, at 11:11 PM, Christian Thalinger wrote:
> On Apr 13, 2011, at 9:01 PM, Vladimir Kozlov wrote:
>> Looks good.
> 
> Thanks, Vladimir.  -- Christian
> 
>> 
>> Vladimir
>> 
>> Christian Thalinger wrote:
>>> [Resending.]
>>> http://cr.openjdk.java.net/~twisti/7018355
>>> 7018355: JSR 292: VM crash in DefNewGeneration::copy_to_survivor_space
>>> Reviewed-by:
>>> There are a couple of unhandled oop usages over potential safepoints
>>> in methodHandles.cpp.  Three of them could be found with
>>> +CheckUnhandledOops, the other ones were either found via
>>> visual-inspection or just were changed for the sake of safety.
>>> src/share/vm/memory/genOopClosures.hpp
>>> src/share/vm/prims/methodHandles.cpp