Request for review (XS): 7036960: TemplateTable::fast_aldc in templateTable_x86_64.cpp uses movptr instead of load_klass

[Christian Thalinger]

On Apr 18, 2011, at 7:39 PM, Tom Rodriguez wrote:
> We should consider hiding klass_offset_in_bytes from most code in the system so that we are forced to use the appropriate MacroAssembler wrappers.  We will probably need to add some more wrappers to cover everything.  I wouldn't be surprised if there are more problems like this lurking.

I agree, we should do that.  -- Christian

> 
> tom
> 
> On Apr 15, 2011, at 4:49 AM, Christian Thalinger wrote:
> 
>> http://cr.openjdk.java.net/~twisti/7036960/
>> 
>> 7036960: TemplateTable::fast_aldc in templateTable_x86_64.cpp uses movptr instead of load_klass
>> Reviewed-by:
>> 
>> The fix is to replace movptr with load_klass.
>> 
>> Additionally I changed all occurrences of movptr instructions loading
>> the class of an oop with load_klass in templateTable_x86_32.cpp (to be
>> some consistent).
>> 
>> src/cpu/x86/vm/templateTable_x86_32.cpp
>> src/cpu/x86/vm/templateTable_x86_64.cpp