review (XS) for 7009346: java/dyn/InvokeDynamicPrintArgs.java fails with NPE on solaris-sparc with -Xcomp

Tom Rodriguez tom.rodriguez at oracle.com
Wed Apr 20 17:04:07 PDT 2011


Thanks!

tom

On Apr 20, 2011, at 12:13 AM, Christian Thalinger wrote:

> On Apr 20, 2011, at 1:31 AM, Tom Rodriguez wrote:
>> http://cr.openjdk.java.net/~never/7009346
>> 
>> 7009346: java/dyn/InvokeDynamicPrintArgs.java fails with NPE on solaris-sparc with -Xcomp
>> Reviewed-by:
>> 
>> The invokespecial method handle adapter attempts to null check its
>> argument before the invoke but it's reading the wrong value so it
>> occasionally throws a spurious NPE.  The fix is to make it look like
>> all the other method handle code that's loading the receiver.  Tested
>> with failing test case.
> 
> Ahh, great!  Thanks for spotting that.  -- Christian



More information about the hotspot-compiler-dev mailing list