review (S) for 7030715: JSR 292 JRuby test/test_super_call_site_caching.rb asserts with +DoEscapeAnalysis

Christian Thalinger christian.thalinger at oracle.com
Wed Apr 27 00:28:50 PDT 2011


On Apr 21, 2011, at 10:47 PM, Tom Rodriguez wrote:
> http://cr.openjdk.java.net/~never/7030715
> 
> 7030715: JSR 292 JRuby test/test_super_call_site_caching.rb asserts with +DoEscapeAnalysis
> Reviewed-by:
> 
> is_static shouldn't be called on unloaded ciMethods.  Instead of just
> adjusting the assert I decided to move the proper logic into ciMethod
> and modify the regular arg_size routine to complain if it's called on
> unloaded methods since it may return the wrong answer in that case.
> Tested with failing test and with CTW to ensure that the new assert
> doesn't trigger for other code.

For the record, I reviewed this one internally and it looks good.  -- Christian


More information about the hotspot-compiler-dev mailing list