review for 7075623: 6990212 broke raiseException in 64 bit

Tom Rodriguez tom.rodriguez at oracle.com
Mon Aug 8 11:50:57 PDT 2011


Thanks Christian and Vladimir.

tom

On Aug 8, 2011, at 1:34 AM, Christian Thalinger wrote:

> Looks good.  -- Christian
> 
> On Aug 5, 2011, at 10:22 PM, Tom Rodriguez wrote:
> 
>> http://cr.openjdk.java.net/~never/7075623
>> 3 lines changed: 0 ins; 0 del; 3 mod; 4699 unchg
>> 
>> 7075623: 6990212 broke raiseException in 64 bit
>> Reviewed-by:
>> 
>> The fix for 6990212 included making the raiseException path do a
>> normal dispatch instead of always using the compiler entry.  The
>> assembly for 64 bit had a few issues.  On x86 the saved sp register is
>> wrong which causes rarg0_code to be killed.  On sparc the code should
>> be passed as an int instead of a ptr which causes problems because of
>> endianness.  I also modified the x86 code to do the same.  Tested with
>> original regression test on sparc/x86 32/64 -Xcomp/-Xmixed.  I also
>> reran the failing JDK regression tests.
>> 
> 



More information about the hotspot-compiler-dev mailing list