Request for reviews (XS): 7079317: Incorrect branch's destination block in PrintoOptoAssembly output

[Tom Rodriguez]

On Aug 15, 2011, at 10:50 AM, Vladimir Kozlov wrote:

> Node::size() for branches calls code in scratch_emit_size() which resets label and block. An other solution for this problem would be save/restore label and block in scratch_emit_size() but it would require a lot more code changes.

Ah.  Fixing scratch_emit_size seems better since it's kind of a surprising behaviour.  It's not that much code is it?

tom

> 
> Vladimir
> 
> Tom Rodriguez wrote:
>> I don't understand how calling insts_size and Node::size causes a bug.  What am I missing?
>> tom
>> On Aug 15, 2011, at 8:58 AM, Vladimir Kozlov wrote:
>>> http://cr.openjdk.java.net/~kvn/7079317/webrev
>>> 
>>> 7079317: Incorrect branch's destination block in PrintoOptoAssembly output
>>> 
>>> After changes for 7063629 PrintoOptoAssembly output shows all branches have B0 as destination block.
>>> Remove unneeded debug verification code which overwrites label and block information for branches. There are other checks there which verify that code size was not changed.