review for 7071307: MethodHandle bimorphic inlining should consider the frequency

Tom Rodriguez tom.rodriguez at oracle.com
Tue Aug 23 16:44:38 PDT 2011


This is a re-review since I added per method handle GWT profiling.

http://cr.openjdk.java.net/~never/7071307
312 lines changed: 270 ins; 15 del; 27 mod; 22101 unchg

7071307: MethodHandle bimorphic inlining should consider the frequency
Reviewed-by:

The fix for 7050554 added a bimorphic inline path but didn't take into
account the frequency of the guarding test.  This ends up treating
both sides of the if as equally frequent which can lead to over
inlining and overflowing the method inlining limits.  The fix is to
grab the frequency from the If and apply that to the branches.

Additionally I added support for per method handle profile collection
since this was required to get good results for more complex programs.
This requires the fix for 7082631 on the JDK side.
http://cr.openjdk.java.net/~never/7082631

I also fixed a problem with the ideal graph printer where debug_orig
printing would go into an infinite loop.

Tested with jruby and vm.mlvm tests.



More information about the hotspot-compiler-dev mailing list